better models and improve validation

internal/domains/sensors/domain.go

@@ -12,28 +12,31 @@ func (s *Sensor) Validate() error {
 	if s.SensorType == "" {
 		return ErrInvalidSensorType
 	}
-	return nil
-}
 
-func (d *SensorData) Validate() error {
-	if d.SensorID == "" {
-		return ErrInvalidSensorIdentifier
+	if s.SamplingInterval == nil {
+		defaultInterval := time.Second * 3600
+		s.SamplingInterval = &defaultInterval
 	}
-	if d.Value == nil {
-		return ErrMissingValue
+
+	if s.ThresholdAbove == nil {
+		defaultAbove := 100.0
+		s.ThresholdAbove = &defaultAbove
 	}
-	if d.Timestamp.IsZero() {
-		d.Timestamp = time.Now()
+
+	if s.ThresholdBelow == nil {
+		defaultBelow := 0.0
+		s.ThresholdBelow = &defaultBelow
 	}
+
 	return nil
 }
 
 func (d *SensorData) IsOutOfRangeAbove(sensor Sensor) bool {
-	return *d.Value > sensor.ThresholdAbove
+	return d.Value > *sensor.ThresholdAbove
 }
 
 func (d *SensorData) IsOutOfRangeBelow(sensor Sensor) bool {
-	return *d.Value < sensor.ThresholdBelow
+	return d.Value < *sensor.ThresholdBelow
 }
 
 func (r *SensorRequest) Validate() error {
@@ -48,19 +51,23 @@ func (r *SensorDataRequest) Validate() error {
 		return ErrInvalidSensorIdentifier
 	}
 
-	if r.To == "" {
-		r.To = time.Now().Format(time.RFC3339)
+	if r.To == nil || *r.To == "" {
+		defaultTo := time.Now().Format(time.RFC3339)
+		r.To = &defaultTo
 	} else {
-		if _, err := time.Parse(time.RFC3339, r.To); err != nil {
-			r.To = time.Now().Format(time.RFC3339)
+		if _, err := time.Parse(time.RFC3339, *r.To); err != nil {
+			defaultTo := time.Now().Format(time.RFC3339)
+			r.To = &defaultTo
 		}
 	}
 
-	if r.From == "" {
-		r.From = time.Now().AddDate(0, 0, -7).Format(time.RFC3339)
+	if r.From == nil || *r.From == "" {
+		defaultFrom := time.Now().AddDate(0, 0, -7).Format(time.RFC3339)
+		r.From = &defaultFrom
 	} else {
-		if _, err := time.Parse(time.RFC3339, r.From); err != nil {
-			r.From = time.Now().AddDate(0, 0, -7).Format(time.RFC3339)
+		if _, err := time.Parse(time.RFC3339, *r.From); err != nil {
+			defaultFrom := time.Now().AddDate(0, 0, -7).Format(time.RFC3339)
+			r.From = &defaultFrom
 		}
 	}
 
@@ -72,4 +79,5 @@ var (
 	ErrInvalidSensorType       = errors.New("sensor type is required")
 	ErrSensorNotFound          = errors.New("sensor not found")
 	ErrMissingValue            = errors.New("sensor value no provided")
+	ErrSensorAlreadyExists     = errors.New("sensor already exists")
 )