add more tests cases

service_a/internal/domains/meteo/file.go

@@ -101,70 +101,67 @@ func (c *CSV) Parse(r io.Reader, fs *FileStats) ([]MeteoData, []RejectedMeteoDat
 func normalize(record H) (*MeteoData, error) {
 	meteoData := &MeteoData{}
 
-	if dateStr, ok := record["Fecha"].(string); ok {
-		t, err := time.Parse("2006/01/02", dateStr)
-		if err != nil {
-			return nil, fmt.Errorf("%w: %v", ErrInvalidDateFormat, err)
-		}
-		meteoData.Timestamp = t
-	} else {
-		return nil, ErrMissingDateField
+	var err error
+
+	meteoData.Timestamp, err = parseDate(record, "Fecha", ErrMissingOrInvalidDateField)
+	if err != nil {
+		return nil, err
 	}
 
-	if location, ok := record["Ciudad"].(string); ok {
-		meteoData.Location = location
-	} else {
-		return nil, ErrMissingCityField
+	meteoData.Location, err = parseString(record, "Ciudad", ErrMissingOrInvalidCityField)
+	if err != nil {
+		return nil, err
 	}
 
-	if maxTempStr, ok := record["Temperatura Máxima (C)"].(string); ok {
-		maxTemp, err := parseFloat(maxTempStr)
-		if err != nil {
-			return nil, fmt.Errorf("%w: %v", ErrInvalidMaxTemp, err)
-		}
-		meteoData.MaxTemp = maxTemp
-	} else {
-		return nil, ErrMissingMaxTempField
+	meteoData.MaxTemp, err = parseFloatField(record, "Temperatura Máxima (C)", ErrMissingOrInvalidMaxTemp)
+	if err != nil {
+		return nil, err
 	}
 
-	if minTempStr, ok := record["Temperatura Mínima (C)"].(string); ok {
-		minTemp, err := parseFloat(minTempStr)
-		if err != nil {
-			return nil, fmt.Errorf("%w: %v", ErrInvalidMinTemp, err)
-		}
-		meteoData.MinTemp = minTemp
-	} else {
-		return nil, ErrMissingMinTempField
+	meteoData.MinTemp, err = parseFloatField(record, "Temperatura Mínima (C)", ErrMissingOrInvalidMinTemp)
+	if err != nil {
+		return nil, err
 	}
 
-	if rainfallStr, ok := record["Precipitación (mm)"].(string); ok {
-		rainfall, err := parseFloat(rainfallStr)
-		if err != nil {
-			return nil, fmt.Errorf("%w: %v", ErrInvalidRainfall, err)
-		}
-		meteoData.Rainfall = rainfall
-	} else {
-		return nil, ErrMissingRainfallField
+	meteoData.Rainfall, err = parseFloatField(record, "Precipitación (mm)", ErrMissingOrInvalidRainfall)
+	if err != nil {
+		return nil, err
 	}
 
-	if cloudinessStr, ok := record["Nubosidad (%)"].(string); ok {
-		cloudiness, err := parseFloat(cloudinessStr)
-		if err != nil {
-			return nil, fmt.Errorf("%w: %v", ErrInvalidCloudiness, err)
-		}
-		meteoData.Cloudiness = cloudiness
-	} else {
-		return nil, ErrMissingCloudinessField
+	meteoData.Cloudiness, err = parseFloatField(record, "Nubosidad (%)", ErrMissingOrInvalidCloudiness)
+	if err != nil {
+		return nil, err
 	}
 
 	return meteoData, nil
 }
 
-func parseFloat(s string) (float32, error) {
-	s = strings.Replace(s, ",", ".", 1)
-	f, err := strconv.ParseFloat(s, 32)
-	if err != nil {
-		return 0, err
+func parseDate(record H, key string, errMissing error) (time.Time, error) {
+	if str, ok := record[key].(string); ok && str != "" {
+		t, err := time.Parse("2006/01/02", str)
+		if err != nil {
+			return time.Time{}, errMissing
+		}
+		return t, nil
 	}
-	return float32(f), nil
+	return time.Time{}, errMissing
+}
+
+func parseString(record H, key string, errMissing error) (string, error) {
+	if str, ok := record[key].(string); ok && str != "" {
+		return str, nil
+	}
+	return "", errMissing
+}
+
+func parseFloatField(record H, key string, errMissing error) (float32, error) {
+	if str, ok := record[key].(string); ok && str != "" {
+		str = strings.Replace(str, ",", ".", 1)
+		f, err := strconv.ParseFloat(str, 32)
+		if err != nil {
+			return 0, errMissing
+		}
+		return float32(f), nil
+	}
+	return 0, errMissing
 }